[#763] allow remote users to be fully deleted, including home collections#794
Open
d-w-moore wants to merge 2 commits intoirods:mainfrom
Open
[#763] allow remote users to be fully deleted, including home collections#794d-w-moore wants to merge 2 commits intoirods:mainfrom
d-w-moore wants to merge 2 commits intoirods:mainfrom
Conversation
When calling to GEN_ADMIN to remove a remote user with separate user and zone parameters, the server will not remove the /tempZone/**/user#hello collections. So, we now force PRC to use an integrated user#zone format.
korydraughn
reviewed
Feb 17, 2026
Comment on lines
+49
to
+51
| def _parse_user_and_zone(user_param, zone_param): | ||
| """Parse out the uesr name ane zone name from USER and ZONE string parameters. | ||
| If the USER string contains # and a non-null-length ZONE spec, ensure that |
Contributor
There was a problem hiding this comment.
The mismatch between the parameter names and the use of USER and ZONE in the comment might confuse people.
Consider replacing USER/ZONE with user_param/zone_param respectively.
| if _object.type == "rodsgroup": | ||
| uz_args = (f"{_object.name}",) | ||
| else: | ||
| uz_args = (f"{_object.name}#{_object.zone}",) |
Contributor
There was a problem hiding this comment.
@d-w-moore Use # noqa: SIM106 to instruct ruff to not report this.
| with self.assertRaises(UserDoesNotExist): | ||
| self.sess.users.get(self.new_user_name) | ||
|
|
||
| def test_deleting_remote_user_including_home_collection_and_trash_artifact__issue_763(self): |
Contributor
There was a problem hiding this comment.
Consider renaming or adding a comment to capture the intent of the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.